Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Chapter reference in LinkedIn Notebook #5

Closed
edglazer opened this issue Jan 20, 2019 · 4 comments
Closed

Incorrect Chapter reference in LinkedIn Notebook #5

edglazer opened this issue Jan 20, 2019 · 4 comments
Assignees

Comments

@edglazer
Copy link

Awesome book and Jupyter notebooks!
There are a couple spots where the notebook for Chapter 4 on LinkedIn references the subdirectory as ch03-linked - though it is actually ch04-linkedin. If I knew how I'd create a pull request, sorry not to be more helpful!

@karelin
Copy link

karelin commented Jan 21, 2019

Similar thing in Chapter 3 on Instagram, and in Chapter 5 with Video course on Google+ (if it is still necessary). And notebook for Appendix B refers to non-existing resources for Chapter 2.

ptwobrussell added a commit that referenced this issue Feb 16, 2019
ptwobrussell added a commit that referenced this issue Feb 16, 2019
@ptwobrussell
Copy link
Collaborator

@edglazer @karelin - Thanks for the help in tracking down these references that got overlooked. I really appreciate it!

@mikhailklassen - Should we remove the Google+ (video course) notebook entirely now that the deprecation date for Google+ is so close? That's the only thing left to consider in closing this issue as far as I know.

@mikhailklassen
Copy link
Owner

@edglazer - I fixed the references to ch03 resources and pointed them to ch04. Thanks for catching that. Some of the chapters got resequenced and we missed those references.

@karelin @ptwobrussell - I've now removed the Google+ (Video Course) notebook, since the lesson material for that notebook is close to that of Mining Text Files. Also, I had forgotten that users who purchased access to the video course on O'Reilly get those notebooks as part of the course files, so this repo can focus entirely on the book-related content.

@mikhailklassen
Copy link
Owner

@karelin - Also now updated the references in Appendix B. Thanks for catching those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants