Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Delete, Get Functionality; Fixed abc import #39

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

rajivsarvepalli
Copy link

I was using this library for some simple SqlAlchemy testing and found the lack of a basic delete somewhat preventative in mocking up queries and session commands. So I decided to add the delete functionality.

This solution is probably not the cleanest, but it does seem to work to a degree. Essentially, .delete()simply deletes whatever is returned by .all(). It seemed to be working in the manner I intended it to be for at least my case.

It should add basic support for deleting within the constraints of this library (it will not unify across queries).

Fixes #32

I also removed importing ABC directly from collections but kept it backwards compatible (or at least I hope so).

Fixes #35

@coveralls
Copy link

coveralls commented Jan 6, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 3b8afc0 on rajivsarvepalli:master into f8af888 on miki725:master.

@rajivsarvepalli
Copy link
Author

Added support for get functionality with dictionaries and integers (the only scalar option allowed currently).

Fixed #38
Fixed #33

@rajivsarvepalli
Copy link
Author

rajivsarvepalli commented Jan 7, 2021

Build fails were a result of failing to install coveralls on pypy due to "Could not build wheels for cryptography which use PEP 517 and cannot be installed directly".

The branch works fine otherwise and has 100% test coverage on python 2.7, python 3.6, and python 3.7.

I changed the Travis file only to fix cryptography for PyPy by downgrading the version to less than 3. The build previously worked fine other than a pip install error for cryptography. With the cryptography downgrade, it passes all tests on travis.

@rajivsarvepalli rajivsarvepalli marked this pull request as ready for review January 7, 2021 00:31
@rajivsarvepalli rajivsarvepalli changed the title Added Delete Support Added Delete, Get Functionality; Fixed abc import Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants