New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Delete, Get Functionality; Fixed abc import #39
base: master
Are you sure you want to change the base?
Conversation
Build fails were a result of failing to install coveralls on pypy due to "Could not build wheels for cryptography which use PEP 517 and cannot be installed directly". The branch works fine otherwise and has 100% test coverage on python 2.7, python 3.6, and python 3.7. I changed the Travis file only to fix cryptography for PyPy by downgrading the version to less than 3. The build previously worked fine other than a pip install error for cryptography. With the cryptography downgrade, it passes all tests on travis. |
I was using this library for some simple SqlAlchemy testing and found the lack of a basic delete somewhat preventative in mocking up queries and session commands. So I decided to add the delete functionality.
This solution is probably not the cleanest, but it does seem to work to a degree. Essentially,
.delete()
simply deletes whatever is returned by.all()
. It seemed to be working in the manner I intended it to be for at least my case.It should add basic support for deleting within the constraints of this library (it will not unify across queries).
Fixes #32
I also removed importing ABC directly from collections but kept it backwards compatible (or at least I hope so).
Fixes #35