Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin does not work with pymdownx.snippet #38

Closed
Addisco opened this issue Dec 5, 2019 · 3 comments
Closed

plugin does not work with pymdownx.snippet #38

Addisco opened this issue Dec 5, 2019 · 3 comments
Labels
enhancement
Projects
plantuml-markdown

Comments

@Addisco
Copy link

Addisco commented Dec 5, 2019

Due to the high priority of 100 of the plantuml extensions it does not work with the snippets extension which registers with a priority of 32.

Currently the plantuml extension processes the Snippets Notation as plantuml within fenced code blocks, instead of having snippets first be replaced.

e.g.

```plantuml
--8<-- "my-plantuml.puml"
```

will render as

plantuml
@mikitex70 mikitex70 added this to To do in plantuml-markdown via automation Dec 5, 2019
@mikitex70
Copy link
Owner

Maybe a fine tuning of the plantuml_markdown extension may be desiderable in many other cases, but why not use the !include macro of PlantUML?
See #37 for an example of configuring the include search path used by PlantUML.

@Addisco
Copy link
Author

Addisco commented Dec 6, 2019

That'll work, too! Thank a lot for the hint!

@mikitex70 mikitex70 moved this from To do to In progress in plantuml-markdown Dec 6, 2019
mikitex70 pushed a commit that referenced this issue Dec 8, 2019
new: usr: added priority option to change plugin priority (refs #38)
702d1a4 
Now the plugin execution priority can be changed if you don't like
default value.
The default should be the most reasonable with most plugins.
mikitex70 pushed a commit that referenced this issue Dec 8, 2019
new: usr: added priority option to change plugin priority (refs #38)
937c0f9 
Now the plugin execution priority can be changed if you don't like
default value.
The default should be the most reasonable with most plugins.
mikitex70 pushed a commit that referenced this issue Dec 8, 2019
new: usr: added priority option to change plugin priority (refs #38)
ce8714e 
Now the plugin execution priority can be changed if you don't like
default value.
The default should be the most reasonable with most plugins.
mikitex70 pushed a commit that referenced this issue Dec 8, 2019
new: usr: added priority option to change plugin priority (refs #38)
db0a867 
Now the plugin execution priority can be changed if you don't like
default value.
The default should be the most reasonable with most plugins.
@mikitex70
Copy link
Owner

Release version 3.2.1 of the plugin.
Changed plugin priority so it works out-of-the-box with the snippets plugin and, maybe, others.
Version 3.2.1 has ha priority configuration property which can be used to change the plugin priority to the desired level in case of conflicts.
Closing this issue as seems to be resolved.
Thanks for reporting this issue.

plantuml-markdown automation moved this from In progress to Done Dec 13, 2019
@mikitex70 mikitex70 mentioned this issue Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
No open projects
plantuml-markdown
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikitex70 @Addisco