Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker image :latest? #38

Open
nicholasklem opened this issue Sep 12, 2020 · 3 comments
Open

Update docker image :latest? #38

nicholasklem opened this issue Sep 12, 2020 · 3 comments

Comments

@nicholasklem
Copy link

I noticed the docker image tagged :latest was not the latest on docker hub:
https://hub.docker.com/r/mikkeloscar/pdb-controller/tags

Is 1 the current recommended docker image?

I made a Dockerfile to make images whenever master is updated:

FROM golang:alpine as builder
RUN apk add --update make git

# bust the cache when master is updated:
ADD https://api.github.com/repos/mikkeloscar/pdb-controller/git/refs/heads/master /version.json

RUN git clone https://github.com/mikkeloscar/pdb-controller.git /pdb-controller

WORKDIR /pdb-controller
ENV GO111MODULE=on
RUN make

FROM alpine
COPY --from=builder /version.json /pdb-controller/build/pdb-controller /
CMD ["/pdb-controller"]

Let me know when I can stop doing this and just pull :latest, :stable or something!

@mikkeloscar
Copy link
Owner

I have added docker push to #26 so when this is merged it will at least keep updating :latest.

@vkobets
Copy link
Contributor

vkobets commented Jan 4, 2023

How can I help you with the docker image?

@mikkeloscar
Copy link
Owner

@vkobets with #49 the :latest image should not be available: mikkeloscar/pdb-controller:latest

If you want to have it e.g. based on tag you're welcome to contribute github action that can tag the image correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants