Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSP (Content Security Policy) rule issue #5

Open
bvaughn opened this issue Apr 5, 2017 · 1 comment
Open

CSP (Content Security Policy) rule issue #5

bvaughn opened this issue Apr 5, 2017 · 1 comment

Comments

@bvaughn
Copy link

bvaughn commented Apr 5, 2017

Hi @mikolalysenko,

I'd love to know your thoughts about this issue recently filed against react-virtualized: bvaughn/react-virtualized/issues/640

I'm using your interval-tree-1d library (and so this one as well) in a masonry component I created recently. I've really enjoyed working with your library, for what it's worth. 😄

@bvaughn
Copy link
Author

bvaughn commented Apr 5, 2017

To add a little more detail, the problem is the use of new Function(...) as explained here. I will submit a PR for your consideration that removes the unnecessary new Function syntax (although at the cost of a few additional bytes).

asutherland added a commit to asutherland/logan that referenced this issue May 28, 2018
This makes the "Filters" button prettier too.

Note that a forked version of binary-search-bounds was adopted that fixes
mikolalysenko/binary-search-bounds#5 wherein
new Function() was being used in an eval style that is to be avoided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant