fixing eclipse PDE suggestions, added TODO for feature #4

mikolayek · Sep 1, 2020 · fa42586 · fa42586
1 parent 2620407
commit fa42586
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/com.hybris.hyeclipse.commons/build.properties b/com.hybris.hyeclipse.commons/build.properties
@@ -3,5 +3,6 @@ output.. = target/classes/
 bin.includes = META-INF/,\
                .,\
                lib/commons-io-2.5.jar,\
-               lib/commons-lang3-3.6.jar
+               lib/commons-lang3-3.6.jar,\
+               plugin.xml
 
diff --git a/com.hybris.hyeclipse.importer/src/com/hybris/yps/hyeclipse/utils/Importer.java b/com.hybris.hyeclipse.importer/src/com/hybris/yps/hyeclipse/utils/Importer.java
@@ -62,6 +62,7 @@ public class Importer {
 	private static final String SPRINGBEANS_FILE = ".springBeans";
 
 	private static final double JVM8_VERSION = 5.6d;
+	private static final double JVM11_VERSION = 1811d;
 
 	public void resetProjectsFromLocalExtensions(File platformHome, IProgressMonitor monitor,  boolean fixClasspath, boolean removeHybrisGenerator, boolean createWorkingSets, boolean useMultiThread, boolean skipJarScanning) throws CoreException {
 		plugin.resetPlatform(platformHome.getAbsolutePath());
@@ -118,6 +119,7 @@ private void importExtensionsNotInWorkspace(IProgressMonitor monitor, File platf
 					fixModules(monitor, extensionHolder);
 				}
 				else {
+					// TODO fix skipping eclipse projects. create them and add to workspace
 					if (DEBUG)
 						Activator.log("Not importing extension [" + extensionHolder + "] because it is not an eclipse project");
 				}

diff --git a/com.hybris.hyeclipse.tests/build.properties b/com.hybris.hyeclipse.tests/build.properties
@@ -1,3 +1,4 @@
 source.. = src/
 bin.includes = META-INF/,\
-               .
+               .,\
+               plugin.xml