fix(mongo): drop migrations table when requested

Closes #4513
mikro-orm · Jul 15, 2023 · 278ba3a · 278ba3a
1 parent 72df9ad
commit 278ba3a
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/packages/mongodb/src/MongoSchemaGenerator.ts b/packages/mongodb/src/MongoSchemaGenerator.ts
@@ -12,6 +12,7 @@ export class MongoSchemaGenerator extends AbstractSchemaGenerator<MongoDriver> {
     options.ensureIndexes ??= true;
     const existing = await this.connection.listCollections();
     const metadata = this.getOrderedMetadata();
+    metadata.push({ collection: this.config.get('migrations').tableName } as any);
 
     /* istanbul ignore next */
     const promises = metadata
@@ -32,11 +33,16 @@ export class MongoSchemaGenerator extends AbstractSchemaGenerator<MongoDriver> {
     await Promise.all(promises);
   }
 
-  async dropSchema(): Promise<void> {
+  async dropSchema(options: { dropMigrationsTable?: boolean } = {}): Promise<void> {
     const db = this.connection.getDb();
     const collections = await db.listCollections().toArray();
     const existing = collections.map(c => c.name);
     const metadata = this.getOrderedMetadata();
+
+    if (options.dropMigrationsTable) {
+      metadata.push({ collection: this.config.get('migrations').tableName } as any);
+    }
+
     const promises = metadata
       .filter(meta => existing.includes(meta.collection))
       .map(meta => this.connection.dropCollection(meta.collection));

diff --git a/tests/features/embeddables/embedded-entities.mongo.test.ts b/tests/features/embeddables/embedded-entities.mongo.test.ts
@@ -252,7 +252,7 @@ describe('embedded entities in mongo', () => {
     const createCollection = jest.spyOn(MongoConnection.prototype, 'createCollection');
     createCollection.mockResolvedValue({} as any);
     await orm.schema.createSchema();
-    expect(createCollection.mock.calls.map(c => c[0])).toEqual(['custom-user', 'parent', 'user']);
+    expect(createCollection.mock.calls.map(c => c[0])).toEqual(['custom-user', 'parent', 'user', 'mikro_orm_migrations']);
     createCollection.mockRestore();
   });
 

diff --git a/tests/features/embeddables/nested-embeddables.mongo.test.ts b/tests/features/embeddables/nested-embeddables.mongo.test.ts
@@ -87,7 +87,7 @@ describe('embedded entities in mongo', () => {
     const createCollection = jest.spyOn(MongoConnection.prototype, 'createCollection');
     createCollection.mockResolvedValue({} as any);
     await orm.schema.createSchema();
-    expect(createCollection.mock.calls.map(c => c[0])).toEqual(['user']);
+    expect(createCollection.mock.calls.map(c => c[0])).toEqual(['user', 'mikro_orm_migrations']);
     createCollection.mockRestore();
   });
 

diff --git a/tests/features/schema-generator/SchemaGenerator.mongo.test.ts b/tests/features/schema-generator/SchemaGenerator.mongo.test.ts
@@ -21,6 +21,10 @@ describe('SchemaGenerator', () => {
     await orm.schema.createSchema();
     collections = await driver.getConnection().listCollections();
     expect(collections).toContain('foo-bar');
+    expect(collections).toContain('mikro_orm_migrations');
+    await orm.schema.dropSchema({ dropMigrationsTable: true });
+    collections = await driver.getConnection().listCollections();
+    expect(collections).toHaveLength(0);
   });
 
   test('refresh collections', async () => {