fix(schema): improve detection of renamed columns

Previously, we only cared about the column type, now we also check if the column is/was a FK or not.

packages/knex/src/schema/SchemaComparator.ts

@@ -339,6 +339,8 @@ export class SchemaComparator {
    */
   private detectColumnRenamings(tableDifferences: TableDifference, inverseTableDiff?: TableDifference): void {
     const renameCandidates: Dictionary<[Column, Column][]> = {};
+    const oldFKs = Object.values(tableDifferences.fromTable.getForeignKeys());
+    const newFKs = Object.values(tableDifferences.toTable.getForeignKeys());
 
     for (const addedColumn of Object.values(tableDifferences.addedColumns)) {
       for (const removedColumn of Object.values(tableDifferences.removedColumns)) {
@@ -348,6 +350,13 @@ export class SchemaComparator {
           continue;
         }
 
+        const wasFK = oldFKs.some(fk => fk.columnNames.includes(removedColumn.name));
+        const isFK = newFKs.some(fk => fk.columnNames.includes(addedColumn.name));
+
+        if (wasFK !== isFK) {
+          continue;
+        }
+
         const renamedColumn = inverseTableDiff?.renamedColumns[addedColumn.name];
 
         if (renamedColumn && renamedColumn?.name !== removedColumn.name) {