fix(core): don't alias formulas in update/delete queries

Closes #5334

packages/core/src/metadata/MetadataDiscovery.ts

@@ -1351,7 +1351,7 @@ export class MetadataDiscovery {
     prop.targetMeta = meta2;
 
     if (!prop.formula && prop.persist === false && [ReferenceKind.MANY_TO_ONE, ReferenceKind.ONE_TO_ONE].includes(prop.kind) && !prop.embedded) {
-      prop.formula = a => `${a}.${prop.fieldNames[0]}`;
+      prop.formula = a => `${a}.${this.platform.quoteIdentifier(prop.fieldNames[0])}`;
     }
   }
 

packages/knex/src/query/QueryBuilderHelper.ts

@@ -118,8 +118,13 @@ export class QueryBuilderHelper {
       const alias2 = this.knex.ref(a).toString();
       const aliased = this.knex.ref(prop.fieldNames[0]).toString();
       const as = alias === null ? '' : ` as ${aliased}`;
+      let value = prop.formula(alias2);
 
-      return this.knex.raw(`${prop.formula(alias2)}${as}`);
+      if (!this.isTableNameAliasRequired(type)) {
+        value = value.replaceAll(alias2 + '.', '');
+      }
+
+      return this.knex.raw(`${value}${as}`);
     }
 
     if (prop?.hasConvertToJSValueSQL) {

tests/issues/GH5334.test.ts

@@ -0,0 +1,49 @@
+import { Collection, Entity, ManyToOne, MikroORM, OneToMany, PrimaryKey, Property } from '@mikro-orm/sqlite';
+
+@Entity()
+class EntityA {
+
+  @PrimaryKey()
+  id!: number;
+
+  @OneToMany(() => EntityB, 'a')
+  bs = new Collection<EntityB>(this);
+
+}
+
+@Entity()
+class EntityB {
+
+  @PrimaryKey()
+  id!: number;
+
+  @Property()
+  test!: string;
+
+  @ManyToOne(() => EntityA, { name: 'id', persist: false })
+  a!: EntityA;
+
+}
+
+let orm: MikroORM;
+
+beforeAll(async () => {
+  orm = await MikroORM.init({
+    dbName: ':memory:',
+    entities: [EntityA, EntityB],
+  });
+  await orm.schema.refreshDatabase();
+});
+
+afterAll(async () => {
+  await orm.close(true);
+});
+
+test('delete entity from persist false relation', async () => {
+  orm.em.create(EntityA, {
+    bs: [{ test: 'qwer' }, { test: 'asdf' }, { test: 'yxcv' }],
+  }, { persist: true });
+
+  await orm.em.flush();
+  await orm.em.nativeDelete(EntityB, { a: 1 });
+});