perf(core): improve speed of inserting new items

Related: #732
mikro-orm · Aug 11, 2020 · bfeb2e3 · marcj · Aug 11, 2020 · B4nan
1 parent eeae2be
commit bfeb2e3
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/packages/core/src/unit-of-work/UnitOfWork.ts b/packages/core/src/unit-of-work/UnitOfWork.ts
@@ -351,10 +351,10 @@ export class UnitOfWork {
    * clean up persist/remove stack from previous persist/remove calls for this entity done before flushing
    */
   private cleanUpStack(stack: AnyEntity[], entity: AnyEntity): void {
-    for (const index in stack) {
-      if (stack[index] === entity) {
-        stack.splice(+index, 1);
-      }
+    const idx = stack.indexOf(entity);
+
+    if (idx !== -1) {
+      stack.splice(idx, 1);
     }
   }