fix: allow masking of passwords with special characters

mikro-orm · Mar 11, 2019 · e2bf26d · e2bf26d
1 parent a2f5772
commit e2bf26d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/utils/Configuration.ts b/lib/utils/Configuration.ts
@@ -60,7 +60,7 @@ export class Configuration {
 
   getClientUrl(hidePassword = false): string {
     if (hidePassword) {
-      return this.options.clientUrl!.replace(/\/\/([^:]+):(\w+)@/, '//$1:*****@');
+      return this.options.clientUrl!.replace(/\/\/([^:]+):(.+)@/, '//$1:*****@');
     }
 
     return this.options.clientUrl!;

diff --git a/tests/MikroORM.test.ts b/tests/MikroORM.test.ts
@@ -27,6 +27,14 @@ describe('MikroORM', () => {
     await expect(MikroORM.init({ dbName: 'test', baseDir: BASE_DIR, entities: [FooBaz2], cache: { enabled: false }, entitiesDirsTs: ['entities'] })).rejects.toThrowError(error);
   });
 
+  test('should hide password from connection uri', async () => {
+    const clientUrl = 'mongodb://dev-vision:Q#ais@2d-Aa_43:ui!0d.ai6d@mongodb-replicaset-0.mongodb-replicaset.dev.svc.cluster.local:27017,mongodb-replicaset-1...';
+    const expected = 'mongodb://dev-vision:*****@mongodb-replicaset-0.mongodb-replicaset.dev.svc.cluster.local:27017,mongodb-replicaset-1...';
+    const conf = new Configuration({ clientUrl } as any, false);
+    const hidden = conf.getClientUrl(true);
+    expect(hidden).toBe(expected);
+  });
+
   test('should init itself with entity manager', async () => {
     const orm = await MikroORM.init({
       entitiesDirs: ['entities'],