fix(core): throw when trying to call em.remove(..., null)

lib/EntityManager.ts

@@ -437,6 +437,8 @@ export class EntityManager<D extends IDatabaseDriver = IDatabaseDriver> {
       return ret ? ret.then(() => 1) : ret;
     }
 
+    this.validator.validateRemoveEmptyWhere(entityName, where);
+
     return this.nativeDelete(entityName, where);
   }
 

lib/entity/EntityValidator.ts

@@ -83,6 +83,12 @@ export class EntityValidator {
     }
   }
 
+  validateRemoveEmptyWhere<T extends AnyEntity<T>>(className: string, where: FilterQuery<T>): void {
+    if (!Utils.isDefined(where, true)) {
+      throw new Error(`You cannot call 'EntityManager.remove()' with empty 'where' parameter. If you want to remove all entities, use 'em.remove(${className}, {})'.`);
+    }
+  }
+
   private validateCollection<T extends AnyEntity<T>>(entity: T, prop: EntityProperty): void {
     if (wrap(entity).isInitialized() && !entity[prop.name as keyof T]) {
       throw ValidationError.fromCollectionNotInitialized(entity, prop);

tests/EntityManager.mysql.test.ts

@@ -1852,6 +1852,11 @@ describe('EntityManagerMySql', () => {
     expect(mock.mock.calls[2][0]).toMatch('commit');
   });
 
+  test('em.remove() with null or undefined in where parameter throws', async () => {
+    expect(() => orm.em.remove(Book2, undefined as any)).toThrowError(`You cannot call 'EntityManager.remove()' with empty 'where' parameter. If you want to remove all entities, use 'em.remove(Book2, {})'.`);
+    expect(() => orm.em.remove(Book2, null)).toThrowError(`You cannot call 'EntityManager.remove()' with empty 'where' parameter. If you want to remove all entities, use 'em.remove(Book2, {})'.`);
+  });
+
   afterAll(async () => orm.close(true));
 
 });