-
|
Error occur when in service I create an entity Using global EntityManager instance methods for context specific actions is disallowed. If you need to work with the global instance's identity map, use |
Beta Was this translation helpful? Give feedback.
Replies: 7 comments 28 replies
-
I am having hard times understanding your english... What about using full sentences? You know, subject, verb, object :] That validation error is throw if you don't have request context set up correctly, or in general when you try to work with global entity manager, outside of request scope handler. In nest the request context is set up automatically, unless you disable it via Ideally create a reproduction project, will be happy to look into it. The realworld example project works fine in this sense, so you can try to compare what you have to that. |
Beta Was this translation helpful? Give feedback.
-
|
Yes, that is my point, by default it is enabled. Only |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
I am not able to run that project |
Beta Was this translation helpful? Give feedback.
-
|
It works fine on my end. I did clean things up a bit and used sqlite instead, you had few configuration options that are not available, like I added logging of the EM id to the user service to ensure it really does use fresh forks, and indeed it does: Here are the changes I have done on my local copy before making it work: diff --git a/package.json b/package.json
index 2f295f8..f189a5b 100755
--- a/package.json
+++ b/package.json
@@ -23,7 +23,7 @@
"dependencies": {
"@mikro-orm/core": "^5.0.0-dev.562",
"@mikro-orm/migrations": "^5.0.0-dev.562",
- "@mikro-orm/mysql": "^5.0.0-dev.562",
+ "@mikro-orm/sqlite": "^5.0.0-dev.562",
"@mikro-orm/nestjs": "^4.3.1",
"@mikro-orm/reflection": "^5.0.0-dev.562",
"@mikro-orm/sql-highlighter": "^1.0.1",
diff --git a/src/app.module.ts b/src/app.module.ts
index df148af..9c21a13 100644
--- a/src/app.module.ts
+++ b/src/app.module.ts
@@ -8,33 +8,21 @@ import { UsersModule } from './modules/users/users.module'
imports: [
MikroOrmModule.forRootAsync({
useFactory: () => ({
- autoLoadEntities: false,
- dbName: 'nuxt_nest',
- debug: ['discovery', 'info', 'query', 'query-params'],
+ // autoLoadEntities: false,
+ dbName: 'test.db',
+ debug: true,
discovery: {
warnWhenNoEntities: true
},
- host: 'localhost',
logging: true,
- password: '123456',
// metadataProvider: TsMorphMetadataProvider,
port: 3306,
- type: 'mysql',
- username: 'root',
- synchronize: true,
+ type: 'sqlite',
entities: [__dirname + '/modules/**/entities/*.entity.js'],
entitiesTs: [__dirname + '/modules/**/entities/*.entity.ts'],
- logger: msg => (new Logger('MikroOrm')).log(msg)
})
}),
UsersModule
]
})
-export class AppModule implements NestModule {
- configure(consumer: MiddlewareConsumer) {
- consumer
- .apply(MikroOrmMiddleware)
- .forRoutes('(.*)')
- // .forRoutes('*')
- }
-}
+export class AppModule { }
diff --git a/src/modules/users/repositories/user.repository.ts b/src/modules/users/repositories/user.repository.ts
index 129322b..b2e7e1a 100644
--- a/src/modules/users/repositories/user.repository.ts
+++ b/src/modules/users/repositories/user.repository.ts
@@ -1,4 +1,4 @@
-import { EntityRepository } from '@mikro-orm/mysql'
+import { EntityRepository } from '@mikro-orm/sqlite'
import { User } from '../entities/user.entity'
diff --git a/src/modules/users/users.controller.ts b/src/modules/users/users.controller.ts
index 6e8e381..dc9e385 100644
--- a/src/modules/users/users.controller.ts
+++ b/src/modules/users/users.controller.ts
@@ -1,6 +1,12 @@
-import { Controller } from '@nestjs/common'
+import {
+ Body,
+ Controller,
+ Post,
+ Get
+} from '@nestjs/common'
import { UsersService } from './users.service'
+import { User } from './entities/user.entity'
@Controller('api/users')
export class UsersController {
@@ -20,4 +26,15 @@ export class UsersController {
return error
}
}
+
+ @Get('test')
+ async createUserGet(): Promise<User> {
+ try {
+ return await this.usersService.createUser({ firstName: 'a', lastName: 'b', password: 'c', email: 'e-' + Math.random() });
+ } catch (error: any) {
+ // log
+
+ return error
+ }
+ }
}
diff --git a/src/modules/users/users.service.ts b/src/modules/users/users.service.ts
index 88cd5bf..01927e2 100644
--- a/src/modules/users/users.service.ts
+++ b/src/modules/users/users.service.ts
@@ -17,6 +17,8 @@ export class UsersService {
): Promise<User> {
let user: User | null = null
+ // @ts-ignore
+ console.log(this.userRepository.em.getContext().id)
// try {
user = await this.userRepository.create(createUserDto)
await this.userRepository.persistAndFlush(user) |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
Looks like there is a bug in the nest/fastify platform or somewhere down that path, that is causing the context to be lost for requests with payload (so post/put/patch). (that issue is about different libraries, but the problem is the same, they also use I was able to make it work with fastify by using nestjs request scopes instead: import { MikroOrmModule } from '@mikro-orm/nestjs'
import { Module, Scope } from '@nestjs/common';
@Module({
imports: [
MikroOrmModule.forRoot({
registerRequestContext: false, // disable the automatic context
scope: Scope.REQUEST, // use nestjs request scopes instead
dbName: 'test.db',
debug: true,
type: 'sqlite',
entities: [__dirname + '/modules/**/entities/*.entity.js'],
entitiesTs: [__dirname + '/modules/**/entities/*.entity.ts'],
}),
UsersModule
]
})
export class AppModule {
}Note that I also used edit: with @Module({
imports: [
MikroOrmModule.forRootAsync({
useFactory: () => ({
registerRequestContext: false,
dbName: 'test.db',
debug: true,
type: 'sqlite',
entities: [__dirname + '/modules/**/entities/*.entity.js'],
entitiesTs: [__dirname + '/modules/**/entities/*.entity.ts'],
}),
scope: Scope.REQUEST,
}),
UsersModule
]
})
export class AppModule {
} |
Beta Was this translation helpful? Give feedback.
-
|
No, the bug did not start with v5. v5 added a validation, so you can see there is a bug, before you just didn't know. Nothing changed in v5 in this regard, just added validation, the problem is not in MikroORM. edit: to be correct, the underlying mechanism changed, we now use async local storage instead of domain api, which obviously does have effect on this. Its usage here is correct, otherwise it woulnd't work with other projects, e.g. with express it works fine, with other FWs it also works fine, using the helper itself works fine, using the context decorator also works fine. The problem is that the async context can be lost due to some other packages down the path. |
Beta Was this translation helpful? Give feedback.
-
|
Alright, thx for the explanation 👍 |
Beta Was this translation helpful? Give feedback.
-
|
That is apply to current situation?
|
Beta Was this translation helpful? Give feedback.
-
|
@B4nan now is other problem if I use loggerFactory: (options: LoggerOptions) => new DatabaseLogger(options) like here https://wanago.io/2021/10/04/api-nestjs-logging-typeorm/ TypeError: Cannot read property 'createLog' of undefined |
Beta Was this translation helpful? Give feedback.
-
|
@B4nan good news I hope nestjs/nest#8837 |
Beta Was this translation helpful? Give feedback.
-
|
Fixt https://github.com/fastify/fastify/blob/e9e889a21cac35e799603a006ccfed65636b390f/lib/contentTypeParser.js (edited) |
Beta Was this translation helpful? Give feedback.
-
|
I found the same issue today with the update to version 5.0.0-rc.2 init options : |
Beta Was this translation helpful? Give feedback.
-
|
I fixed CLI version and reinstall dependencies but I still have error |
Beta Was this translation helpful? Give feedback.
-
|
This is validation error, not seeing it in v4 does not mean its not there, v4 did not have this validation. And as I said, this stack trace is definitely not from RC.2 core package. Just check the code I linked, |
Beta Was this translation helpful? Give feedback.
-
|
I'm really sorry I took your time |
Beta Was this translation helpful? Give feedback.
-
|
ouch totally missed that, you know if it would be minimal repro, it would be easier to spot :P anyway, I just added validation for this situation |
Beta Was this translation helpful? Give feedback.
-
:) |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Oh jeez, people suggesting to disable validation without understanding, and being upvoted for that... Thanks for linking this, will try to add some meaningful response there. |
Beta Was this translation helpful? Give feedback.
-
|
I read the stackoverflow and came here, thanks for putting the correct answer up. I just want to point out that the design on It's too easy to just use global and solve any immediate development issues. Sometimes the issues you get from this can only be noticed in production which makes the issue rather nasty and perhaps hard to even debug. I would suggest totally removing this config so that people don't use it by accident and instead perhaps add an API with a warning in the name for anyone that would need it - something along the lines of |
Beta Was this translation helpful? Give feedback.
-
|
Yeah agreed, I am planning to make the warning more informative instead of just suggesting the I am not sure if removing it is a good idea, but I might be biased, as it would also mean I need to modify all the tests that depend on this. And there are a lot of them... :] Or maybe we should keep this available only via env vars? |
Beta Was this translation helpful? Give feedback.
Fixt https://github.com/fastify/fastify/blob/e9e889a21cac35e799603a006ccfed65636b390f/lib/contentTypeParser.js (edited)