My getter implementation is being changed on load

[xenoterracide]

Describe the bug
Mongo implementation changing my getter

To Reproduce

import { Entity, PrimaryKey } from '@mikro-orm/core';
import * as uuid from 'uuid-mongodb';

@Entity({ abstract: true })
export abstract class BaseMongoAggregate<
    Id extends string,
  >
{
  constructor(id: uuid.MUUID = uuid.v4()) {
    super();
    this._id = id;
  }

  @PrimaryKey({ type: 'uuid' })
  protected _id: uuid.MUUID;

  get id(): Id {
    return this._id.toString() as Id;
  }

  protected set id(arg: Id) {
    this._id = uuid.from(arg);
  }

if you debug an instance returned by find an MUUID is returned, not a string, you can see that the getter implementation is not what I defined in the debugger.

Expected behavior
when calling instance.id it should use my getter, and not have the implementation replaced.

Versions

└─ services-core@workspace:.
   └─ @mikro-orm/mongodb@npm:5.6.3 [8316d] (via npm:^5.6.3 [8316d])
❯ yarn why @mikro-orm/nestjs
└─ services-core@workspace:.
   └─ @mikro-orm/nestjs@npm:5.1.5 [8316d] (via npm:^5.1.5 [8316d])
❯ yarn why @mikro-orm/core
└─ services-core@workspace:.
   └─ @mikro-orm/core@npm:5.6.3 [8316d] (via npm:^5.6.3 [8316d])
❯ node --version
v18.12.1
❯ yarn why typescript
├─ @ts-morph/common@npm:0.7.5
│  └─ typescript@patch:typescript@npm%3A4.1.6#~builtin<compat/typescript>::version=4.1.6&hash=bda367 (via patch:typescript@~4.1.3#~builtin<compat/typescript>)
│
├─ import-sort-parser-typescript@npm:6.0.0
│  └─ typescript@patch:typescript@npm%3A3.9.10#~builtin<compat/typescript>::version=3.9.10&hash=bda367 (via patch:typescript@^3.2.4#~builtin<compat/typescript>)
│
└─ services-core@workspace:.
   └─ typescript@patch:typescript@npm%3A4.7.3#~builtin<compat/typescript>::version=4.7.3&hash=bda367 (via patch:typescript@4.7.3#~builtin<compat/typescript>)
❯ yarn why mongodb
├─ @mikro-orm/mongodb@npm:5.6.3
│  └─ mongodb@npm:4.13.0 (via npm:4.13.0)
│
├─ @mikro-orm/mongodb@npm:5.6.3 [8316d]
│  └─ mongodb@npm:4.13.0 (via npm:4.13.0)
│
├─ mongodb-memory-server-core@npm:8.0.4
│  └─ mongodb@npm:4.2.0 (via npm:^4.1.3)
│
└─ services-core@workspace:.
   └─ mongodb@npm:4.2.2 (via npm:~4.2.0)

[B4nan]

Right, I know what's happening. The getter is supposed to be defined only for the "serialized primary key", which is a way the ORM handles ObjectId/string duality in mongo (so kinda the same as you are trying, but for ObjectIds). But it is used regardless of how you define the entity, because of how we setup the metadata defaults.

[xenoterracide]

then why if I don't use @SerializedPrimaryKey, does it still behave that way?

[B4nan]

Yeah that's a bug for sure, looking at that right now, but its apparently more complex than it seems.

[xenoterracide]

is it possible to move this discussion back to a bug then? I'm not sure if it is

[B4nan]

This should do it

7004100

[xenoterracide]

thanks