Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nested embeddables #1017

Closed
kodeine opened this issue Nov 2, 2020 · 2 comments · Fixed by #1311
Closed

Add support for nested embeddables #1017

kodeine opened this issue Nov 2, 2020 · 2 comments · Fixed by #1311
Assignees
@B4nan
Labels
enhancement New feature or request
Milestone
4.x

Comments

@kodeine
Copy link

kodeine commented Nov 2, 2020 •
edited
Loading

error
@B4nan
Copy link
Member

B4nan commented Nov 2, 2020

Nesting of embeddales is not supported currently.

@B4nan B4nan changed the title bug in Embedded decorators Add support for nested embeddables Nov 2, 2020
@B4nan B4nan added enhancement New feature or request help wanted Extra attention is needed labels Nov 2, 2020
@B4nan B4nan removed their assignment Nov 2, 2020
@j
Copy link

j commented Dec 9, 2020

@B4nan Nested embedding is really the main reason to use MongoDB. Without it, this library is super limited for the MongoDB users. I tried coming back to MikroORM lately and had to revert back. :(

@B4nan B4nan self-assigned this Dec 17, 2020
@B4nan B4nan removed the help wanted Extra attention is needed label Dec 17, 2020
@B4nan B4nan added this to the 4.x milestone Dec 17, 2020
B4nan added a commit that referenced this issue Jan 16, 2021
@B4nan
feat(core): add support for nested embedddables [WIP]
5d596f0 
Closes #1017
@B4nan B4nan mentioned this issue Jan 16, 2021
Merged
B4nan added a commit that referenced this issue Jan 17, 2021
@B4nan
feat(core): add support for nested embedddables [WIP]
1d60ee9 
Closes #1017
B4nan added a commit that referenced this issue Jan 17, 2021
@B4nan
feat(core): add support for nested embedddables [WIP]
2e4a558 
Closes #1017
B4nan added a commit that referenced this issue Jan 18, 2021
@B4nan
feat(core): add support for nested embedddables
6a2fdec 
Embeddables can now be nested, both in object and inlined mode. The mode of the root
embedded property is always propagated, e.g. there is no way to nest object embeddable
inside inlined one and vice versa.

Closes #1017
B4nan added a commit that referenced this issue Jan 18, 2021
@B4nan
feat(core): add support for nested embedddables
87a1b4e 
Embeddables can now be nested, both in object and inlined mode. The mode of the root
embedded property is always propagated, e.g. there is no way to nest object embeddable
inside inlined one and vice versa.

`assign` helper now also allows using `mergeObjects` with embeddadble properties.

Closes #1017
B4nan added a commit that referenced this issue Jan 18, 2021
@B4nan
feat(core): add support for nested embedddables
e4df1f8 
Embeddables can now be nested, both in object and inlined mode. The mode of the root
embedded property is always propagated, e.g. there is no way to nest object embeddable
inside inlined one and vice versa.

`assign` helper now also allows using `mergeObjects` with embeddadble properties.

Closes #1017
B4nan added a commit that referenced this issue Jan 18, 2021
@B4nan
feat(core): add support for nested embedddables
1db5137 
Embeddables can now be nested, both in object and inlined mode. The mode of the root
embedded property is always propagated, e.g. there is no way to nest object embeddable
inside inlined one and vice versa.

`assign` helper now also allows using `mergeObjects` with embeddadble properties.

Closes #1017
B4nan added a commit that referenced this issue Jan 18, 2021
@B4nan
feat(core): add support for nested embedddables
07a10b0 
Embeddables can now be nested, both in object and inlined mode. The mode of the root
embedded property is always propagated, e.g. there is no way to nest object embeddable
inside inlined one and vice versa.

`assign` helper now also allows using `mergeObjects` with embeddadble properties.

Closes #1017
B4nan added a commit that referenced this issue Jan 18, 2021
@B4nan
feat(core): add support for nested embedddables (#1311)
aee2abd 
Embeddables can now be nested, both in object and inlined mode. The mode of the root
embedded property is always propagated, e.g. there is no way to nest object embeddable
inside inlined one and vice versa.

`assign` helper now also allows using `mergeObjects` with embeddadble properties.

Closes #1017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@B4nan B4nan

Labels
enhancement New feature or request
Projects
None yet
Milestone
4.x
Development

Successfully merging a pull request may close this issue.

feat(core): add support for nested embedddables mikro-orm/mikro-orm
3 participants
@j @B4nan @kodeine