Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

em.commit doesn't throw when a sql transaction commit fails #1176

Closed
rhyek opened this issue Dec 7, 2020 · 0 comments · Fixed by #1177
Closed

em.commit doesn't throw when a sql transaction commit fails #1176

rhyek opened this issue Dec 7, 2020 · 0 comments · Fixed by #1177
Assignees

Comments

@rhyek
Copy link
Contributor

rhyek commented Dec 7, 2020

Extracting this small issue out of #1160 and providing fix via PR.

Basically, when using explicit transactions and explicit begin, commit, and rollback methods, if the commit statement fails on the database side, this is not currently being caught by mikroorm and em.commit resolves incorrectly. It should rethrow the error given by the knex transaction context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants