Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(knex): reject in commit() method if commit statement fails #1177

Merged
merged 1 commit into from
Dec 8, 2020
Merged

fix(knex): reject in commit() method if commit statement fails #1177

merged 1 commit into from
Dec 8, 2020

Conversation

rhyek
Copy link
Contributor

@rhyek rhyek commented Dec 7, 2020

Closes #1176

@B4nan B4nan changed the title fix(knex): reject in AbstractSqlConnection.commit if commit statement fails fix(knex): reject in commit() method if commit statement fails Dec 8, 2020
@B4nan B4nan merged commit f3beb7f into mikro-orm:master Dec 8, 2020
@B4nan
Copy link
Member

B4nan commented Dec 8, 2020

Thanks, interesting that this is intended behaviour in knex, lol...

@B4nan
Copy link
Member

B4nan commented Dec 8, 2020

Available in 4.3.4-dev.8 for testing

@rhyek rhyek mentioned this pull request Dec 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

em.commit doesn't throw when a sql transaction commit fails
2 participants
@rhyek @B4nan