Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array of embeddables #1369

Closed
ramiel opened this issue Jan 30, 2021 · 1 comment · Fixed by #1496
Closed

Array of embeddables #1369

ramiel opened this issue Jan 30, 2021 · 1 comment · Fixed by #1496
Assignees
@B4nan
Labels
enhancement New feature or request

Comments

@ramiel
Copy link

ramiel commented Jan 30, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
I'm not sure wether it's possible to have an embeddable as array, e.g.

  @Embedded(() => [Item], { object: true })
  items: Array<Item> = [];

where Item is an embeddable (like the above or using Collection). On DB, items would be an array of Item objects. At the moment this seems to be not possible but maybe I'm doing something wrong

Describe the solution you'd like
The same described above or with a Collection
@ramiel ramiel added the enhancement New feature or request label Jan 30, 2021
@ramiel ramiel changed the title Embeddable arrays Array of embeddables Jan 30, 2021
@icex
Copy link

icex commented Feb 4, 2021 •
edited
Loading

I'm also looking for a solution for this. I'm currently trying to use JsonType, but I have issues with updates not registered in computeChangeSets :( #1395

@B4nan B4nan self-assigned this Feb 16, 2021
B4nan added a commit that referenced this issue Feb 26, 2021
@B4nan
feat(core): support embeddable arrays
168cd5e 
```ts
  @Embedded(() => Address, { array: true })
  addresses: Address[] = [];
```

Closes #1369
@B4nan B4nan mentioned this issue Feb 26, 2021
Merged
B4nan added a commit that referenced this issue Feb 26, 2021
@B4nan
feat(core): support embeddable arrays (#1496)
57b605c 
```ts
  @Embedded(() => Address, { array: true })
  addresses: Address[] = [];
```

Closes #1369
@B4nan B4nan mentioned this issue Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@B4nan B4nan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): support embeddable arrays mikro-orm/mikro-orm
3 participants
@ramiel @B4nan @icex