Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-incrementing version feature does not escape field names #2401

Closed
parisholley opened this issue Nov 10, 2021 · 1 comment · Fixed by #2402
Closed

Auto-incrementing version feature does not escape field names #2401

parisholley opened this issue Nov 10, 2021 · 1 comment · Fixed by #2402

Comments

@parisholley
Copy link
Contributor 

InvalidFieldNameException: update "table" set "foo" = 'bar', "versionId" = versionId + 1 where "id" = '2' - column "versionid" does not exist

unfortunately, postgres is case sensitive :(
@B4nan
Copy link
Member

B4nan commented Nov 10, 2021

You mean it should be quoted, not escaped, right?

parisholley added a commit to parisholley/mikro-orm that referenced this issue Nov 11, 2021
@parisholley
fix(knex): quote version column (mikro-orm#2401)
900c402
@B4nan B4nan mentioned this issue Nov 11, 2021
Merged
B4nan pushed a commit that referenced this issue Nov 11, 2021
@parisholley
fix(knex): quote version column (#2402)
5bbbd15 
Closes #2401
@parisholley parisholley mentioned this issue Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(knex): quote version column parisholley/mikro-orm
2 participants
@parisholley @B4nan