Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(knex): quote version column #2402

Merged
merged 1 commit into from
Nov 11, 2021
Merged

fix(knex): quote version column #2402

merged 1 commit into from
Nov 11, 2021

Conversation

parisholley
Copy link
Contributor

@parisholley parisholley commented Nov 11, 2021

Closes #2401

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

Merging #2402 (900c402) into master (ae1c788) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2402   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          186       186           
  Lines        10378     10378           
  Branches      2275      2275           
=========================================
  Hits         10378     10378           
Impacted Files Coverage Δ
packages/knex/src/query/QueryBuilderHelper.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae1c788...900c402. Read the comment docs.

@B4nan B4nan changed the title fix(knex): quote version column (#2401) fix(knex): quote version column Nov 11, 2021
@B4nan B4nan merged commit 5bbbd15 into mikro-orm:master Nov 11, 2021
@B4nan
Copy link
Member

B4nan commented Nov 11, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-incrementing version feature does not escape field names
3 participants