Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference.load() should return Loaded<> when populating #3755

Closed
parisholley opened this issue Nov 15, 2022 · 1 comment
Closed

Reference.load() should return Loaded<> when populating #3755

parisholley opened this issue Nov 15, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone
6.0

Comments

@parisholley
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When calling reference.load(), the return type is Promise<T> instead of Promise<Loaded<T,P>>

Describe the solution you'd like
Add more overloads to the load type
@parisholley parisholley added the enhancement New feature or request label Nov 15, 2022
@parisholley parisholley changed the title Reference.load() should return populated object Reference.load() should return Loaded<> when populating Nov 15, 2022
parisholley added a commit to parisholley/mikro-orm that referenced this issue Nov 15, 2022
@parisholley
feat(mikro-orm#3755): return loaded type when populating a reference
71368bc
@B4nan B4nan mentioned this issue Nov 16, 2022
Closed
@B4nan
Copy link
Member

B4nan commented Feb 5, 2023

And looks like with the changes I made in #4012 we can also resolve this, I just need to drop the function overload.

@B4nan B4nan added this to the 6.0 milestone Feb 5, 2023
B4nan added a commit that referenced this issue Feb 5, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
dce3fe2 
Closes #3755
@B4nan B4nan closed this as completed Feb 5, 2023
B4nan added a commit that referenced this issue Feb 5, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
4392dbc 
Closes #3755
B4nan added a commit that referenced this issue Feb 12, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
629d2e0 
Closes #3755
B4nan added a commit that referenced this issue Feb 17, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
5f605e9 
Closes #3755
B4nan added a commit that referenced this issue Feb 17, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
8049516 
Closes #3755
B4nan added a commit that referenced this issue Feb 26, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
8392ca9 
Closes #3755
B4nan added a commit that referenced this issue Mar 19, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
00df452 
Closes #3755
B4nan added a commit that referenced this issue Apr 6, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
1fd4036 
Closes #3755
B4nan added a commit that referenced this issue Apr 10, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
cfcb295 
Closes #3755
B4nan added a commit that referenced this issue Apr 12, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
ebd5af6 
Closes #3755
B4nan added a commit that referenced this issue Apr 26, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
86d49d4 
Closes #3755
B4nan added a commit that referenced this issue May 14, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
2601dc5 
Closes #3755
B4nan added a commit that referenced this issue May 14, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
6501bf2 
Closes #3755
B4nan added a commit that referenced this issue May 24, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
c6e0fae 
Closes #3755
B4nan added a commit that referenced this issue May 26, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
c788f60 
Closes #3755
B4nan added a commit that referenced this issue Jun 11, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
7ec4b4b 
Closes #3755
B4nan added a commit that referenced this issue Sep 10, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
c143cf3 
Closes #3755
B4nan added a commit that referenced this issue Sep 20, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
81503c3 
Closes #3755
B4nan added a commit that referenced this issue Sep 24, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
eea8451 
Closes #3755
B4nan added a commit that referenced this issue Sep 30, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
80b548c 
Closes #3755
B4nan added a commit that referenced this issue Oct 2, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
1de91bd 
Closes #3755
B4nan added a commit that referenced this issue Oct 17, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
3dc5942 
Closes #3755
B4nan added a commit that referenced this issue Oct 21, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
6e02055 
Closes #3755
B4nan added a commit that referenced this issue Oct 25, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
d776a81 
Closes #3755
B4nan added a commit that referenced this issue Nov 2, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
9c4391d 
Closes #3755
B4nan added a commit that referenced this issue Nov 5, 2023
@B4nan
feat(core): return Loaded type from Ref.load()
bc3ffa9 
Closes #3755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
6.0
Development

Successfully merging a pull request may close this issue.

feat(core): return loaded type when populating a reference parisholley/mikro-orm
2 participants
@parisholley @B4nan