feat(core): allow filtering in Collection.loadCount()
#3958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manu-urba
changed the title
Codecov ReportBase: 99.76% // Head: 99.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3958 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 214 214
Lines 13715 13720 +5
Branches 3208 3212 +4
=======================================
+ Hits 13683 13688 +5
Misses 30 30
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
B4nan
reviewed
Jan 22, 2023
manu-urba
force-pushed
the
feat-collection-loadcount-cond
branch
from
3e45ba1
to
4732dad
Compare
B4nan
reviewed
Jan 22, 2023
|
Sorry for the confusion in these commits and force pushes, something really weird kept happening with git and husky. Everything should be done now though. |
B4nan
reviewed
Jan 23, 2023
B4nan
approved these changes
Jan 23, 2023
Eslint doesn't like this else statement here.
B4nan
reviewed
Jan 23, 2023
B4nan
reviewed
Jan 23, 2023
Co-authored-by: Martin Adámek <banan23@gmail.com>
|
There you go, everything should be done now. By the way thank you for detailed review and for explaining me every single thing that wasn't right. |
B4nan
changed the title
Collection.loadCount()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #3527.