Fix undefined variables in migration #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Column names are capitals in MySQL 8.0.19 (MySQL Community Server - GPL). Without the aliases, the columns will be returned like COLUMN_NAME, DATA_TYPE, COLUMN_DEFAULT etc. and causing undefined column properties (for example line 95) and breaking the migration if the table structure is existent (creating the structure from scratch works fine, it is just the updating that is broken).
|
Interesting, so can this be considered as "fixing support for mysql 8"? As that sounds more understandable from the changelog perspective. Also please fix the tests, should be just about fixing those snapshots. Otherwise we are good to merge. |
fix snapshot
|
I don't know if it is only MySQL 8, I just started using the migrator and got loads of undefined errors and after looking further into it, it was because of these queries returning the data in capitals. |
|
Well the fix is only in the mysql helper, so I think we can call it this way. Other drivers use different approach/queries to get the column list, so they should be fine. Anyway, thanks, will release it as part of 3.5 probably later this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Column names are capitals in MySQL 8.0.19 (MySQL Community Server - GPL). Without the aliases, the columns will be returned like COLUMN_NAME, DATA_TYPE, COLUMN_DEFAULT etc. and causing undefined column properties (for example line 95) and breaking the migration if the table structure is existent (creating the structure from scratch works fine, it is just the updating of existing databases that is broken).