Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom serializer does not take into account getters #4859

Closed
ivanpondal opened this issue Oct 20, 2023 · 1 comment · Fixed by #4860
Closed

Custom serializer does not take into account getters #4859

ivanpondal opened this issue Oct 20, 2023 · 1 comment · Fixed by #4860
Labels
bug Something isn't working

Comments

@ivanpondal
Copy link
Contributor

ivanpondal commented Oct 20, 2023 •
edited

Describe the bug
When trying to use custom property serialization on class methods it gets ignored.

To Reproduce
Steps to reproduce the behavior:

  1. Define an entity method property with custom serialize function.
  2. Serialize and compare result.

Expected behavior
Custom serialization should run.

Versions

Dependency Version
node ?
typescript ?
mikro-orm ?
your-driver ?
@ivanpondal
Copy link
Contributor Author

I'll be working on this, created the issue only to have a tracker id 👍

@ivanpondal ivanpondal mentioned this issue Oct 20, 2023
Merged
@B4nan B4nan added the bug Something isn't working label Oct 21, 2023
B4nan pushed a commit that referenced this issue Oct 23, 2023
@ivanpondal
fix(serialization): run custom serializer on getters (#4860)
e76836e 
Closes #4859
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(serialization): run custom serializer on getters ivanpondal/mikro-orm
2 participants
@B4nan @ivanpondal