upsertMany error within nullable and composite key reference.

[z4o4z]

Describe the bug

ORM generates incorrect Ref for nullable and composite key references.

Here's an example:

class EntityA {
  @Primary()
  id!: string;
  
  @Primary()
  envID!: string;
}

class EntityB {
  @Primary()
  id!: string;
  
  @Primary()
  envID!: string;

  @Property({ type: 'text' })
  name!: string;

  @ManyToOne(() => EntityA, {
    name: 'entity_a_id',
    default: null,
    onDelete: 'set default',
    nullable: true,
    fieldNames: ['entity_a_id', 'env_id'],
  })
  entityA: Ref<EntityA> | null = null;


}

when I try to upsert entities like below, I get an error ValidationError: Value for EntityB.envID is required, 'undefined' found.

await this.em.upsertMany(EntityA, [{ id: 'entity-a-1', envID: 'env-1' }, { id: 'entity-a-2', envID: 'env-1' }]);

await this.em.upsertMany(EntityB, [{ id: 'entity-b-1', envID: 'env-1', name: 'entity-b-1', entityA: ref({ id: 'entity-a-1', envID: 'env-1' }) }, { id: 'entity-b-2', envID: 'env-1', name: 'entity-b-2', entityA: ref({ id: 'entity-a-2', envID: 'env-1' }) }]);

After some debugging, I've found that finalize method in the QueryBuilderHelper adds entity_a_id as a returning field, cause it has default value, I guess that makes sense. But when the returned value is mapped the original entityA ref (that has both id and envID) replaced with incorrect one (that has only id, no env id), it happens cause in the mapReturnedValues entityA is set to entity_a_id that is returned from the DB, but it should be a composite value (array of entity_a_id and envID).

Not sure what's the best solution here, probably ignore nullable + composite key references during mapReturnedValues?

Reproduction

see above

What driver are you using?

@mikro-orm/postgresql

MikroORM version

5.9.4

Node.js version

v16.19.0

Operating system

macOS

Validations

• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Slack.
• The provided reproduction is a minimal reproducible example of the bug.

[B4nan]

Backported the fix from v6 here: a7e9a82