Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mapping): add support for embeddables #514

Merged
merged 1 commit into from Apr 26, 2020
Merged

feat(mapping): add support for embeddables #514

merged 1 commit into from Apr 26, 2020

Conversation

B4nan
Copy link
Member

@B4nan B4nan commented Apr 25, 2020 •
edited

Embeddables are classes which are not entities themselves, but are embedded in entities.

@Embeddable()
class Address {

  @Property()
  street!: string;

  @Property()
  city!: string;

  @Property()
  country!: string;

}

@Entity()
class User {

  @PrimaryKey()
  id!: number;

  @Embedded(() => Address)
  address!: Address;

}

@B4nan B4nan force-pushed the embeddables branch 2 times, most recently from 6683a62 to 69d179e Compare April 25, 2020 12:06
@B4nan B4nan force-pushed the embeddables branch 2 times, most recently from 7efcf14 to 24f507f Compare April 26, 2020 20:16
@lgtm-com
Copy link

lgtm-com bot commented Apr 26, 2020

This pull request introduces 1 alert when merging 24f507f into 4e80a9e - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@B4nan B4nan force-pushed the embeddables branch 4 times, most recently from eb45258 to 410a21b Compare April 26, 2020 21:18
@B4nan
feat(mapping): add support for embeddables
113c52a 
Embeddables are classes which are not entities themselves, but are embedded in entities.

```typescript
@embeddable()
class Address {

  @Property()
  street!: string;

  @Property()
  city!: string;

  @Property()
  country!: string;

}

@entity()
class User {

  @PrimaryKey()
  id!: number;

  @Embedded(() => Address)
  address!: Address;

}
```
@B4nan B4nan merged commit ff897e4 into dev Apr 26, 2020
@B4nan B4nan deleted the embeddables branch April 26, 2020 21:28
@B4nan B4nan mentioned this pull request Apr 27, 2020
Merged
B4nan added a commit that referenced this pull request Apr 29, 2020
@B4nan
feat(mapping): add support for embeddables (#514)
535e168 
Embeddables are classes which are not entities themselves, but are embedded in entities.

```typescript
@embeddable()
class Address {

  @Property()
  street!: string;

  @Property()
  city!: string;

  @Property()
  country!: string;

}

@entity()
class User {

  @PrimaryKey()
  id!: number;

  @Embedded(() => Address)
  address!: Address;

}
```
@B4nan B4nan mentioned this pull request Apr 30, 2020
Closed
46 tasks
B4nan added a commit that referenced this pull request May 3, 2020
@B4nan
feat(mapping): add support for embeddables (#514)
96d8232 
Embeddables are classes which are not entities themselves, but are embedded in entities.

```typescript
@embeddable()
class Address {

  @Property()
  street!: string;

  @Property()
  city!: string;

  @Property()
  country!: string;

}

@entity()
class User {

  @PrimaryKey()
  id!: number;

  @Embedded(() => Address)
  address!: Address;

}
```
@murbanowicz
Copy link

Does it work with all dB? I mean pg and mongodb as well?

@B4nan
Copy link
Member Author

B4nan commented May 20, 2020

Yes it does, it works for all drivers: https://github.com/mikro-orm/mikro-orm/pull/514/files#diff-75e1159357f882865c05f8e43f1506a7

B4nan added a commit that referenced this pull request May 21, 2020
@B4nan
feat(mapping): add support for embeddables (#514)
eb0303b 
Embeddables are classes which are not entities themselves, but are embedded in entities.

```typescript
@embeddable()
class Address {

  @Property()
  street!: string;

  @Property()
  city!: string;

  @Property()
  country!: string;

}

@entity()
class User {

  @PrimaryKey()
  id!: number;

  @Embedded(() => Address)
  address!: Address;

}
```
B4nan added a commit that referenced this pull request Jun 1, 2020
@B4nan
feat(mapping): add support for embeddables (#514)
7d9bfeb 
Embeddables are classes which are not entities themselves, but are embedded in entities.

```typescript
@embeddable()
class Address {

  @Property()
  street!: string;

  @Property()
  city!: string;

  @Property()
  country!: string;

}

@entity()
class User {

  @PrimaryKey()
  id!: number;

  @Embedded(() => Address)
  address!: Address;

}
```
B4nan added a commit that referenced this pull request Jun 5, 2020
@B4nan
feat(mapping): add support for embeddables (#514)
83d92f9 
Embeddables are classes which are not entities themselves, but are embedded in entities.

```typescript
@embeddable()
class Address {

  @Property()
  street!: string;

  @Property()
  city!: string;

  @Property()
  country!: string;

}

@entity()
class User {

  @PrimaryKey()
  id!: number;

  @Embedded(() => Address)
  address!: Address;

}
```
B4nan added a commit that referenced this pull request Jun 16, 2020
@B4nan
feat(mapping): add support for embeddables (#514)
c434100 
Embeddables are classes which are not entities themselves, but are embedded in entities.

```typescript
@embeddable()
class Address {

  @Property()
  street!: string;

  @Property()
  city!: string;

  @Property()
  country!: string;

}

@entity()
class User {

  @PrimaryKey()
  id!: number;

  @Embedded(() => Address)
  address!: Address;

}
```
B4nan added a commit that referenced this pull request Aug 2, 2020
@B4nan
feat(mapping): add support for embeddables (#514)
598f3a2 
Embeddables are classes which are not entities themselves, but are embedded in entities.

```typescript
@embeddable()
class Address {

  @Property()
  street!: string;

  @Property()
  city!: string;

  @Property()
  country!: string;

}

@entity()
class User {

  @PrimaryKey()
  id!: number;

  @Embedded(() => Address)
  address!: Address;

}
```
B4nan added a commit that referenced this pull request Aug 9, 2020
@B4nan
feat(mapping): add support for embeddables (#514)
0fa06b1 
Embeddables are classes which are not entities themselves, but are embedded in entities.

```typescript
@embeddable()
class Address {

  @Property()
  street!: string;

  @Property()
  city!: string;

  @Property()
  country!: string;

}

@entity()
class User {

  @PrimaryKey()
  id!: number;

  @Embedded(() => Address)
  address!: Address;

}
```
@cupcakearmy cupcakearmy mentioned this pull request Aug 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@B4nan @murbanowicz