Nullable BigInt column is trying to save NULL as string

[pepakriz]

When I have an entity with nullable bigint and I'm trying to save null value, it tries to convert null to string.

To Reproduce

@Entity()
export class AppVersion {

    @PrimaryKey()
    public id: number = null;

    @Property({ type: BigIntType, nullable: true })
    public disabledSince: number | null = null;

}

const appVersion = new AppVersion();
await em.persistAndFlush(appVersion);

It can be fixed by changing methods in the BigIntType.ts like this:

  convertToDatabaseValue(value: any, platform: Platform): any {
    if (!value) {
      return value;
    }

    return '' + value;
  }

  convertToJSValue(value: any, platform: Platform): any {
    if (!value) {
      return value;
    }

    return '' + value;
  }

Is it a good solution?

[B4nan]

Yeah agreed

[B4nan]

Closing as fixed in v4 via 2e0ef58