Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix path on windows for esmodules #2641

Merged
merged 3 commits into from
Jan 16, 2022
Merged

refactor: fix path on windows for esmodules #2641

merged 3 commits into from
Jan 16, 2022

Conversation

PodaruDragos
Copy link
Contributor

@PodaruDragos PodaruDragos commented Jan 16, 2022

I was no able to remove those eslint things on line 609-610.

This closes #2631 (comment).

Edit: I would really appreciate if you can merge this since I really can't work on windows without this. ( only with wsl and that is really slow ).

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2022

Codecov Report

Merging #2641 (e01d853) into master (fcdb236) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master    #2641      +/-   ##
===========================================
- Coverage   100.00%   99.98%   -0.02%     
===========================================
  Files          191      191              
  Lines        11135    11139       +4     
  Branches      2535     2536       +1     
===========================================
+ Hits         11135    11137       +2     
- Misses           0        1       +1     
- Partials         0        1       +1     
Impacted Files Coverage Δ
packages/core/src/utils/Utils.ts 99.52% <66.66%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcdb236...e01d853. Read the comment docs.

@B4nan B4nan changed the title fix path on windows for esmodules refactor: fix path on windows for esmodules Jan 16, 2022
@B4nan B4nan merged commit 6366576 into mikro-orm:master Jan 16, 2022
@B4nan
Copy link
Member

B4nan commented Jan 16, 2022

Would be great to compile all the knoledge you get from this into an article or something

@PodaruDragos
Copy link
Contributor Author

Would be great to compile all the knoledge you get from this into an article or something

yeah. it should be:

Esmodules in nodejs
Please don't even try. Thanks for reading 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running Migrations with es modules
3 participants