Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema): support mysql 8 #2961

Merged
merged 1 commit into from Mar 27, 2022
Merged

feat(schema): support mysql 8 #2961

merged 1 commit into from Mar 27, 2022

Conversation

B4nan
Copy link
Member

@B4nan B4nan commented Mar 27, 2022

All ORM tests are now using mysql8, which supports check constraints.
Also fixes several issues with schema diffing in mysql8 (additional queries).

All ORM tests are now using mysql8, which supports check constraints.
Also fixes several issues with schema diffing in mysql8 (additional queries).
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2022

Codecov Report

Merging #2961 (b8ff889) into master (b513b16) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2961   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          193       193           
  Lines        11806     11817   +11     
  Branches      2725      2726    +1     
=========================================
+ Hits         11806     11817   +11     
Impacted Files Coverage Δ
packages/core/src/platforms/Platform.ts 100.00% <ø> (ø)
packages/postgresql/src/PostgreSqlPlatform.ts 100.00% <ø> (ø)
packages/sqlite/src/SqlitePlatform.ts 100.00% <ø> (ø)
packages/knex/src/schema/SchemaComparator.ts 100.00% <100.00%> (ø)
packages/mysql/src/MySqlSchemaHelper.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b513b16...b8ff889. Read the comment docs.

@B4nan B4nan merged commit acc960e into master Mar 27, 2022
@B4nan B4nan deleted the mysql8 branch March 27, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants