Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(knex): always skip virtual properties in returning clause #3699

Merged
merged 4 commits into from
Nov 5, 2022
Merged

Conversation

B4nan
Copy link
Member

@B4nan B4nan commented Nov 5, 2022

Closes #3698

@B4nan B4nan changed the title fix(knex): do not require virtual properties when seeding fix(knex): always skip virtual properties in returning clause Nov 5, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 99.96% // Head: 99.96% // No change to project coverage 👍

Coverage data is based on head (cb63a27) compared to base (6461b73).
Patch has no changes to coverable lines.

❗ Current head cb63a27 differs from pull request most recent head cf0d989. Consider uploading reports for the commit cf0d989 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3699   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         211      211           
  Lines       13262    13264    +2     
  Branches     3069     3070    +1     
=======================================
+ Hits        13258    13260    +2     
  Misses          4        4           
Impacted Files Coverage Δ
packages/knex/src/AbstractSqlDriver.ts 100.00% <ø> (ø)
packages/core/src/utils/Utils.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@B4nan B4nan merged commit c084dde into master Nov 5, 2022
@B4nan B4nan deleted the patch-1 branch November 5, 2022 23:43
@B4nan B4nan restored the patch-1 branch January 10, 2023 19:11
@B4nan B4nan deleted the patch-1 branch January 10, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants