Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postgres): use explicit schema in table identifier when altering comments #4123

Merged
merged 2 commits into from
Mar 12, 2023

Conversation

B4nan
Copy link
Member

@B4nan B4nan commented Mar 12, 2023

Closes #4108

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (549beec) 99.68% compared to head (44aa537) 99.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4123      +/-   ##
==========================================
- Coverage   99.68%   99.66%   -0.02%     
==========================================
  Files         214      214              
  Lines       13799    13847      +48     
  Branches     3237     3258      +21     
==========================================
+ Hits        13755    13801      +46     
- Misses         41       43       +2     
  Partials        3        3              
Impacted Files Coverage Δ
packages/mariadb/src/MariaDbSchemaHelper.ts 100.00% <ø> (ø)
packages/knex/src/schema/SchemaGenerator.ts 100.00% <100.00%> (ø)
packages/knex/src/schema/SchemaHelper.ts 100.00% <100.00%> (ø)
packages/mysql/src/MySqlSchemaHelper.ts 100.00% <100.00%> (ø)
packages/postgresql/src/PostgreSqlSchemaHelper.ts 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@B4nan B4nan merged commit 60d96de into master Mar 12, 2023
@B4nan B4nan deleted the postgresql_qualified_table_comments branch March 12, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@Property comment with PostgreSQL driver generates invalid SQL
3 participants