feat(discovery): use both entity name and path as key in MetadataStorage #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decorators are using static MetadataStorage, now the keys includes also the path to entity, so technically it is possible to have multiple entities with the same name (although not in the same ORM context, but with multiple ORM instances). This should also fix issues with HMR and "multiple property decorators used" validation error.
B4nan
added a commit
that referenced
this pull request
Apr 18, 2020
Decorators are using static MetadataStorage, now the keys includes also the path to entity, so technically it is possible to have multiple entities with the same name (although not in the same ORM context, but with multiple ORM instances). This should also fix issues with HMR and "multiple property decorators used" validation error.
B4nan
added a commit
that referenced
this pull request
Apr 19, 2020
Decorators are using static MetadataStorage, now the keys includes also the path to entity, so technically it is possible to have multiple entities with the same name (although not in the same ORM context, but with multiple ORM instances). This should also fix issues with HMR and "multiple property decorators used" validation error.
B4nan
added a commit
that referenced
this pull request
Apr 25, 2020
Decorators are using static MetadataStorage, now the keys includes also the path to entity, so technically it is possible to have multiple entities with the same name (although not in the same ORM context, but with multiple ORM instances). This should also fix issues with HMR and "multiple property decorators used" validation error.
B4nan
added a commit
that referenced
this pull request
Apr 26, 2020
Decorators are using static MetadataStorage, now the keys includes also the path to entity, so technically it is possible to have multiple entities with the same name (although not in the same ORM context, but with multiple ORM instances). This should also fix issues with HMR and "multiple property decorators used" validation error.
Merged
B4nan
added a commit
that referenced
this pull request
Apr 29, 2020
Decorators are using static MetadataStorage, now the keys includes also the path to entity, so technically it is possible to have multiple entities with the same name (although not in the same ORM context, but with multiple ORM instances). This should also fix issues with HMR and "multiple property decorators used" validation error.
B4nan
added a commit
that referenced
this pull request
May 3, 2020
Decorators are using static MetadataStorage, now the keys includes also the path to entity, so technically it is possible to have multiple entities with the same name (although not in the same ORM context, but with multiple ORM instances). This should also fix issues with HMR and "multiple property decorators used" validation error.
B4nan
added a commit
that referenced
this pull request
May 21, 2020
Decorators are using static MetadataStorage, now the keys includes also the path to entity, so technically it is possible to have multiple entities with the same name (although not in the same ORM context, but with multiple ORM instances). This should also fix issues with HMR and "multiple property decorators used" validation error.
B4nan
added a commit
that referenced
this pull request
Jun 1, 2020
Decorators are using static MetadataStorage, now the keys includes also the path to entity, so technically it is possible to have multiple entities with the same name (although not in the same ORM context, but with multiple ORM instances). This should also fix issues with HMR and "multiple property decorators used" validation error.
B4nan
added a commit
that referenced
this pull request
Jun 5, 2020
Decorators are using static MetadataStorage, now the keys includes also the path to entity, so technically it is possible to have multiple entities with the same name (although not in the same ORM context, but with multiple ORM instances). This should also fix issues with HMR and "multiple property decorators used" validation error.
B4nan
added a commit
that referenced
this pull request
Jun 16, 2020
Decorators are using static MetadataStorage, now the keys includes also the path to entity, so technically it is possible to have multiple entities with the same name (although not in the same ORM context, but with multiple ORM instances). This should also fix issues with HMR and "multiple property decorators used" validation error.
B4nan
added a commit
that referenced
this pull request
Aug 2, 2020
Decorators are using static MetadataStorage, now the keys includes also the path to entity, so technically it is possible to have multiple entities with the same name (although not in the same ORM context, but with multiple ORM instances). This should also fix issues with HMR and "multiple property decorators used" validation error.
B4nan
added a commit
that referenced
this pull request
Aug 9, 2020
Decorators are using static MetadataStorage, now the keys includes also the path to entity, so technically it is possible to have multiple entities with the same name (although not in the same ORM context, but with multiple ORM instances). This should also fix issues with HMR and "multiple property decorators used" validation error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decorators are using static MetadataStorage, now the keys includes also the path to entity, so technically it is possible to have multiple entities with the same name (although not in the same ORM context, but with multiple ORM instances).
This should also fix issues with HMR and "multiple property decorators used" validation error.
Runtime metadata (
orm.getMetadata()) are kept intact, so the key there is just the entity name.