Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mysql): apply current context when fetching auto_increment_increment #5280

Merged
merged 5 commits into from Feb 26, 2024

Conversation

steve-keep
Copy link
Contributor

@steve-keep steve-keep commented Feb 26, 2024

Closes #5279

Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks! same fix needs to be applied to the mariadb driver

packages/mysql/src/MySqlDriver.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.73%. Comparing base (73094ef) to head (84fa091).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #5280    +/-   ##
========================================
  Coverage   99.73%   99.73%            
========================================
  Files         222      222            
  Lines       16865    16867     +2     
  Branches     4124     3609   -515     
========================================
+ Hits        16821    16823     +2     
  Misses         44       44            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@B4nan B4nan changed the title fix(mysql): apply current context when fetching auto_increment_increment fix(mysql): apply current context when fetching auto_increment_increment Feb 26, 2024
@B4nan B4nan merged commit c8021da into mikro-orm:master Feb 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot Create Entity in MySQL When Max Pool Set to 1
2 participants