Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use Domain API instead of async_hooks #58

Merged
merged 1 commit into from
May 27, 2019
Merged

perf: use Domain API instead of async_hooks #58

merged 1 commit into from
May 27, 2019

Commits on May 27, 2019

  1. perf: use Domain API instead of async_hooks 

    After observing huge performance impact when using async_hooks when concurrent requests are involved, Domain API seems like much better fit for this task. Even though they are deprecated, they will most likely stay till another (stable) solution will be available.

So far async_hooks caused memory leaks even without ORM being involved. Simple express server with async_hooks tracing enabled created dozens of references in CONTEXT map without properly destroying them (the destroy hook was simply not called for those resource).
    Martin Adamek committed May 27, 2019
    Configuration menu
    Copy the full SHA
    a77bdfd View commit details
    Browse the repository at this point in the history