-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add section for Relationship Loading Strategy #588
Conversation
Signed-off-by: Will Soto <willsoto@users.noreply.github.com>
Co-authored-by: Martin Adámek <banan23@gmail.com>
Co-authored-by: Martin Adámek <banan23@gmail.com>
Co-authored-by: Martin Adámek <banan23@gmail.com>
Signed-off-by: Will Soto <willsoto@users.noreply.github.com>
Feedback applied. One thing I was thinking was whether or not we should have a section dedicated to describing all the various strategies. I know only 2 are supported now, but if there are plans to support more in the future it could be useful to have them all described up-front. I'm thinking something like this |
But that is the page you just added, isn't it? It's called loading strategy, we have 2 of those, and it describes both of them. Sure we could be more verbose if that is what you mean (feel free to do so :]) |
Maybe we should rename the page to loading strategies? WDYT? |
haha I suppose verbosity is one way to describe what I want. Yes, you are right that it is all there already but I am thinking more in the case that I already know about the feature, but I just need to look up the various supported strategies at a glance. Could be useful, but it was just a thought. I'll think on it more.
I don't have a strong preference either way. I titled it |
The name is fine, what I meant is to use |
Oh! Got it haha Sure that is fine I think, I named it singular since most (all?) of the titles are singular (like |
Point taken. Will change. @B4nan do you want page title and sidebar title changed? |
Yes please, change it on all places, including the file name (and therefore url). |
Should be good, I just did it via the github UI, I hope you plan on squash merging this too 😅 |
Sure, no worries, I am squash merging everything (I even accidentally squash merged the v3 PR so the history is totally fucked up with v3 changes being in single commit 🤣) |
@B4nan I'm okay not adding that section for right now. You are free to merge this unless there are other changes you'd like made. |
It's good to have it there, thanks! :] |
First pass. Open to feedback of course.
#440