fix: multiple database connection with autoLoadEntities
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toLoadEntities for multiple databases
…tions where it does not correctly register the providers for each database connection. Also update `forFeature` to accept different combination for contextName with option or not.
B4nan
approved these changes
Feb 25, 2022
B4nan
changed the title
autoLoadEntities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a user who does not use
autoLoadEntitiesI discovered today multiple database connections currently does not work with it. I have added some extra tests aroundautoLoadEntitiesand createdMikroOrmEntitiesStorageto manage them.I also updated
forFeatureto work with options and contextName param.