fix: return same EM fork for EM from core and driver packages #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there were 2 provides registered for the EM: - one from core package - one from each installed driver package (knex/mongo) This brought issues with the nestjs request scopes, as the repositories depend on the core EM, while users usually inject from the driver package. Now the driver specific provider just depends on the core EM and returns it, so both injection tokens behaves the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there were 2 provides registered for the EM:
This brought issues with the nestjs request scopes, as the repositories depend on the core EM, while users usually inject from the driver package.
Now the driver specific provider just depends on the core EM and returns it, so both injection tokens behaves the same.
Closes #67