Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't execute in a context if it's not in babel.contextKeys? #177

Closed
sebastian-marinescu opened this issue Jan 25, 2019 · 5 comments
Closed

Comments

@sebastian-marinescu
Copy link
Contributor

Hello and thank you for this great Extra.

I have a multi-context setup, where the "web" context is just a redirector (to the most probable language supported) and holder for common-content.

So if visiting a content in this context, or editing a resource, I get this in the logs:

[Babel] Could not load menu for context key: "web". Try to check "babel.contextKeys" in System Settings. If this is intended, you can ignore this warning.

Could this message be deactivated (by a setting maybe)?

@goldsky
Copy link
Collaborator

goldsky commented Feb 5, 2019

It's a warning only.

@sebastian-marinescu
Copy link
Contributor Author

Yes, I know -
but why does it always show in the error-logs, when debug=0 (so only real errors should be shown)?

@zaigham
Copy link
Contributor

zaigham commented Jul 16, 2020

Here it is sending on modX::LOG_LEVEL_ERROR level: https://github.com/mikrobi/babel/blob/master/core/components/babel/elements/plugins/babel.plugin.php#L84
We could change it to modX::LOG_LEVEL_WARN.

@sebastian-marinescu
Copy link
Contributor Author

I think that would make a lot more sense, what do you think @goldsky ?

@Jako
Copy link
Collaborator

Jako commented Mar 27, 2024

This should be fixed with 3.2.0.

@Jako Jako closed this as completed Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants