Idea: Fire custom event when TV values have been synchronized

[arjen-t]

It would be nice if a custom event is triggered with the TV IDs in combination with the resource IDs that have changed after syncing the TV values.

Why?
This allows other Extras, that do something with this TV value for a specific resource, to still hook into the changes.

Suggested event name:
BabelTvsSynchronized

[Jako]

Can you use this event?

babel/core/components/babel/processors/mgr/resource/link.class.php

Lines 115 to 121 in 61c0dfc

	$this->modx->invokeEvent('OnBabelLink', [
	'context_key' => $this->getProperty('context'),
	'original_id' => $this->object->get('id'),
	'original_resource' => &$this->object,
	'target_id' => $this->targetResource->get('id'),
	'target_resource' => &$this->targetResource
	]);

If not, you have to create a PR.

[arjen-t]

unfortunately not, since when updating a resource the TV's synchronization also has to be tracked. I will create a PR as suggested.

babel/core/components/babel/src/Babel.php

Lines 280 to 314 in 61c0dfc

	public function synchronizeTvs($resourceId)
	{
	$linkedResources = $this->getLinkedResources($resourceId);
	/* check if Babel TV has been initiated for the specified resource */
	if (empty($linkedResources)) {
	$linkedResources = $this->initBabelTvById($resourceId);
	}
	/* synchronize the TVs of linked resources */
	$syncTvs = $this->getOption('syncTvs');
	if (empty($syncTvs) || !is_array($syncTvs)) {
	/* there are no TVs to synchronize */
	return;
	}
	foreach ($syncTvs as $tvId) {
	/* go through each TV which should be synchronized */
	$tv = $this->modx->getObject('modTemplateVar', $tvId);
	if (!$tv) {
	continue;
	}
	$tvValue = $tv->getValue($resourceId);
	foreach ($linkedResources as $linkedResourceId) {
	/* go through each linked resource */
	if ($resourceId == $linkedResourceId) {
	/* don't synchronize resource with itself */
	continue;
	}
	$tv->setValue($linkedResourceId, $tvValue);
	}
	$tv->save();
	}
	$this->modx->cacheManager->refresh();
	}

I assume this is the best place to trigger that event? Which will cause 2 scenarios.

1. If the resource gets linked, the next events will be fired in the following order: OnBabelTvsSynchronized and then event OnBabelLink.
2. If the resource gets updated/saved, the event OnBabelTvsSynchronized gets fired.

I will call the event OnBabelTvsSynchronized which is inline with the OnBabelLink convention.

The event OnBabelTvsSynchronized will be only triggered when their are changes.