Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change creationTime to correct name and calculate lastChange time for folder #54

Merged
merged 6 commits into from
May 20, 2016

Conversation

mguiral
Copy link
Member

@mguiral mguiral commented Apr 28, 2016

No description provided.

@coveralls
Copy link

coveralls commented Apr 28, 2016

Coverage Status

Coverage remained the same at 48.82% when pulling a45be7a on calculateLastChangeTime into 529f117 on develop.

@@ -45,7 +45,7 @@ class ItemStat
long long sizeOnDisk; /// size on hard-drive (takes hardlinks into account)
long long accessTime;
long long modificationTime;
long long creationTime;
long long lastChangeTime;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what is the different with modificationTime?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lastChangeTime = statInfos.st_ctime;
http://linux.die.net/man/2/stat
time of last status change

Maybe need a more explicit variable name and also some doc.

@coveralls
Copy link

coveralls commented Apr 28, 2016

Coverage Status

Coverage remained the same at 48.82% when pulling 357b4d6 on calculateLastChangeTime into 529f117 on develop.

@coveralls
Copy link

coveralls commented Apr 28, 2016

Coverage Status

Coverage remained the same at 48.82% when pulling ca8703b on calculateLastChangeTime into 529f117 on develop.

@coveralls
Copy link

coveralls commented Apr 29, 2016

Coverage Status

Coverage increased (+11.5%) to 60.34% when pulling 7b49a27 on calculateLastChangeTime into 529f117 on develop.

@cchampet
Copy link
Collaborator

TODO: up version to v1.3.0

@cchampet cchampet merged commit 262391f into develop May 20, 2016
@cchampet cchampet deleted the calculateLastChangeTime branch November 10, 2016 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants