Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce typescript #68

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pschoffer
Copy link

@mikuso, what do you think of this approach to converting to typescript?

As long as we adjust the packaging logic, we can only convert file by file as we go. So I only converted few basic classes to have some type help and my typescript compiler didn't complain.

I also tweaked the mocha tests to be happy with mix of js and ts files and they all seem to be passing.

I think the biggest advantage is that it can be done very incrementally and also not all files need to be converted in the end.

@pschoffer
Copy link
Author

I didn't spend the time figuring out the packaging and publishing flow. Most likely there will be extra work needed there to also extract type files from the ts sources along the js outputs. But I am happy to do that if you think we should go forward on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant