Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mikuso, what do you think of this approach to converting to typescript?
As long as we adjust the packaging logic, we can only convert file by file as we go. So I only converted few basic classes to have some type help and my typescript compiler didn't complain.
I also tweaked the mocha tests to be happy with mix of js and ts files and they all seem to be passing.
I think the biggest advantage is that it can be done very incrementally and also not all files need to be converted in the end.