Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Issue in importing RPCServerClient in typescript #74

Closed
wants to merge 3 commits into from

Conversation

rohittiwari-dev
Copy link
Contributor

[issue]:
The imports for RPCServerClient Types for typescript declaration was causing issue as it was importing from serverClient.d.ts instead of server-client.d.ts as originaly server-client.js exists and not serverClient.js

[example]:
in javascript : import RPCServerClient from 'ocpp-rpc/lib/server-client'
in typescript : import RpcServerClient from "ocpp-rpc/lib/serverClient";

[after fix]
in javascript : import RPCServerClient from 'ocpp-rpc/lib/server-client'
in typescript : import RpcServerClient from "ocpp-rpc/lib/server-client";

test passes all test cases on npm run test

This PR fixes this issue for production level uses.

@mikuso
Copy link
Owner

mikuso commented Mar 29, 2024

Thanks. I hope you don't mind but I've applied these changes in a new commit to keep the git history a bit cleaner. Change is now published to npm in 2.1.1.

@mikuso mikuso closed this Mar 29, 2024
@rohittiwari-dev
Copy link
Contributor Author

rohittiwari-dev commented Mar 29, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants