AggregationSchemes for Maximum and Minimum. #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwf
force-pushed
the
max_min_monitoring
branch
from
41e2da9
to
275c09a
Compare
dwf
force-pushed
the
max_min_monitoring
branch
from
275c09a
to
fe47ff8
Compare
|
It is issue #129 . |
|
So it is. |
|
I added a Concatenate scheme for completeness. |
|
Sorry, forgot about this PR. It looks good. I have one question: do you think that concatenate aggregator should always create an extra dim? For example, in your test |
|
That would make things simpler wouldn't it? Changed in 7e8a556.
|
|
Cool, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprised to find these didn't already exist.Fixes #129.