Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce source_shapes for H5PYDataset #392

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Introduce source_shapes for H5PYDataset #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion fuel/datasets/hdf5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,13 +488,29 @@ def load(self):
shapes = None
source_shapes.append(shapes)
self.data_sources = tuple(data_sources)
# TODO why is this a tuple, while `.sources` is a list?
self.source_shapes = tuple(source_shapes)
# This exists only for request sanity checking purposes.
self.in_memory_subset = Subset(
slice(None), len(self.data_sources[0]))
else:
# I have a feeling we can probably get data shapes in a single way
# regardless of whether data is in memory or not
source_shapes = []
for source_name, subset in zip(self.sources, self.subsets):
# Reuse this use case from a few lines up
if source_name in self.vlen_sources:
shapes = subset.index_within_subset(
handle[source_name].dims[0]['shapes'],
slice(None))
else:
if self.user_given_subset != slice(None):
raise NotImplementedError('Not entirely sure how to handle user slices yet')
shapes = handle[source_name].shape
source_shapes.append(shapes)

self.source_shapes = source_shapes
self.data_sources = None
self.source_shapes = None
self.in_memory_subset = None

self._out_of_memory_close()
Expand Down