-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vscode on drac #86
Conversation
milatools/cli/commands.py
Outdated
def code_drac(cluster:str, account:str, time:float, cpus:int, mem:int, gpu:str): | ||
"""Open a remote VSCode session on a drac compute node.""" | ||
url = f"https://jupyterhub.{cluster}.computecanada.ca" | ||
_user="sogagne" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line _user="sogagne"
is only to test with my user
Adding the line To test, run the following: |
Does this open vscode in the browser? Or is it an app link that opens the vscode client? |
Currently opening vscode in a browser (the url built by the above command is https://jupyterhub.cedar.computecanada.ca/hub/spawn?gpus=gpu%3A0&next=%2Fhub%2Fuser%2Fsogagne%2Fcode-server&account=rrg-bengioy-ad_cpu&runtime=1.0&nprocs=1&memory=1000) as this was the simplest / fastest way to have proof of concept to use what is alrady implemented by DRAC. Once the server is running it should be possible to connect to it with a local client but I haven't looked into that. It might also be possible to only use the vscode module This is very imperfect, but the web browser solution might cover most of the user needs. |
0092632
to
f3a94ab
Compare
I'll check about the module load, if we can keep everything in the same command, with the same syntax, that would definitely be best. |
I'm in favour of any solution that is not time consuming for a first version, then build or take the time to rebuild properly afterwards. I don't think we have to see the web solution as a final version, discrediting other solutions. A different API for a plug and play solution might not be too bad a trade off. There's a possibility we failed a bit at communicating that DRAC already offered a solution for vs code. We could even aim at a first that could only be an advertisement for that solution, while we build something better in the meantime |
f3a94ab
to
4548805
Compare
4548805
to
655afb3
Compare
655afb3
to
033fc00
Compare
I don't seem to be able to sign in with my GitHub account in the web browser VsCode. Do you think that's intended or a bug? I'm currently testing out if adding the code-server module could help with installing extensions on the compute node. So far, it doesn't look like it. I'm gonna try to understand what they do with jupyterlab to make this work. |
VS Code in web browser on DRAC cluster