Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React geonode viewer #2

Merged
merged 1,370 commits into from Nov 17, 2016
Merged

React geonode viewer #2

merged 1,370 commits into from Nov 17, 2016

Conversation

milafrerichs
Copy link
Owner

No description provided.

davisc and others added 30 commits June 22, 2016 09:25
Added LDAP install and configure steps in Admin workshop
AttributeError: 'NoneType' object has no attribute 'name'

jazzband/django-polymorphic#201
…anting a string for creating the feature store.
dj_database_url formats the port as an integer, whereas gsconfig is w…
…t-and-html-formats

Enable .txt and .html formats exports for metadata
addition to previous patch: format port as str
Lock in the version until issue GeoNode#2544 is resolved
gsconfig now utilizes an attribution dictionary and bumped to newest …
Heading "Docker Usage" was not rendered correctly.
Alessio Fabiani and others added 28 commits October 19, 2016 18:14
One approach to the problem described in
GeoNode#2646

This patch uses the Django field definition to get the length, so this can be
controlled from that one place and won't get out of sync.
This subtle misunderstanding of Python tends to cause confusing bugs.

Suppose you have a definition statement like 'def function(keys=[]): ...'
This def statement is evaluated once, at import time, to create a function
object. It is at this time that '[]' is evaluated, and it is that ONE
list object which is retained as the default value for 'keys'.
Python doesn't store the expression and re-evaluate it every time the
default is needed, it evaluates it once at import time and the resulting
value is passed for every call where that arg is not given.

To explain this with code, the effect is something like this:

    default_keys = []
    def function(keys=default_keys):
        ...

When function() is called with a value for keys, no problem will be seen.
Even when it is called with no value for keys, and we default to that list,
you might not see a problem. The problem that tends to happen unpredictably
is that the mutable default value is mutated. Those changes are persistent
and globally visible to any call of the function which uses the default.

Then the default value is non-empty. Or information leaks across calls
that shouldn't be leaking. Or the same dict keeps growing forever.

To avoid this, we can use a sentinel value such as None, and then check
for that value in the body of the function. It is a cheap safeguard against
situations that can be very annoying.
Fix the Resources section on profile detail page to work when no data…
* Fixed dead link [ci skip]

* Fixed some doc links [ci skip]

* Fixed License header in some po files

* Fixed packaging files copyright

* Added OSGeo copyright and CC-SA in documentation
…ng certain filetypes to be packaged, loading.gif was the most noticeable.
…ons.

 2696 Part 1 - GNIP - Better management of View and Download permissions.

 - Fix flake8 formatting issues
GeoNode#2696 Part 1 - GNIP - Better management of View and Download permissions.
- Fix minor typo with brackets
Add a new template for editing/showing new maps and change just the
viewer to use the new ol3-react based viewer
add all kinds of assets/deps for the ol3-react based viewer
ol3-cesium is a little tedious but is needed for 3d globe
@milafrerichs milafrerichs merged commit 9eb9d91 into master Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet