Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react prosemirror track changes, fiduswriter-remove-invalid-json-comments.diff: No such file or directory #1

Open
milahu opened this issue Mar 27, 2023 · 2 comments

Comments

@milahu
Copy link
Owner

milahu commented Mar 27, 2023

your prosemirror track changes implementation

credit goes to fiduswriter
i just "connected the dots"

still lots of features missing for a fully "tracked" editor
in effect, i wanted a fully-featured GUI git client ...
making snapshots (commits) is simple, but then you want to edit the snapshots
and also handle multiple files ... what i call browserforge
https://github.com/milahu/browserforge

Can you please help me with the react implementation of the above functionality?

i passionately hate reactjs because its slow, so i cant help you there
but writing such integrations is trivial ...
just use an existing "prosemirror in react" integration, and go from there
https://duckduckgo.com/?q=prosemirror+react

fiduswriter-remove-invalid-json-comments.diff: No such file or directory

read the source

https://github.com/milahu/prosemirror-track-changes-demo/blob/b8e08c7788816d426d6a50a216c7f414d022f520/install-fiduswriter.sh#L40

either

wget -O fiduswriter-remove-invalid-json-comments.diff https://github.com/fiduswriter/fiduswriter/pull/1143.diff

or use a "jsonc to json" converter, to remove json comments

@Ramnath-Karthikesan
Copy link

Ramnath-Karthikesan commented Mar 27, 2023

Thanks for the suggestions. The no such file or directory issue has been rectified after using the wget command. But now I'm facing another issue while installing. This is my terminal output:

$ bash install-fiduswriter.sh
patching file node_modules/biblatex-csl-converter/package.json
Reversed (or previously applied) patch detected! Skipping patch.
1 out of 1 hunk ignored
Cloning into 'fiduswriter'...
remote: Enumerating objects: 912, done.
remote: Counting objects: 100% (912/912), done.
remote: Compressing objects: 100% (740/740), done.
remote: Total 912 (delta 108), reused 641 (delta 77), pack-reused 0
Receiving objects: 100% (912/912), 2.27 MiB | 901.00 KiB/s, done.
Resolving deltas: 100% (108/108), done.
patching file fiduswriter/base/package.json
patching file fiduswriter/document/package.json
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED

How can I solve this?

@milahu
Copy link
Owner Author

milahu commented Mar 27, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants