Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template literals in npm module #155

Closed
BarryThePenguin opened this issue Apr 20, 2017 · 4 comments
Closed

template literals in npm module #155

BarryThePenguin opened this issue Apr 20, 2017 · 4 comments
Labels

Comments

@BarryThePenguin
Copy link

Looks like the published code in npm still has template literals. Using livereactload@next in IE11 ends up with a SCRIPT1014: Invalid character error

See https://unpkg.com/livereactload@4.0.0-beta.1/lib/reloading.js, specifically

console.warn(`LiveReactload: You are providing two arguments to the module.hot.onUpdate hook, and we are
                ignoring the first argument. You may have copied and pasted a webpack hook. For compatibility, we are
                accepting this, and it will probably work, but please remove the first argument to avoid confusion.`)
@BarryThePenguin
Copy link
Author

BarryThePenguin commented Apr 20, 2017

There's a "postcompile": "cp src/reloading.js lib/" step in package.json that reverts the babel compiled file. That could be removed. Or src/reloading.js could be made to work without template literals (or any other ES6 features)

@EugeneZ
Copy link
Contributor

EugeneZ commented Apr 20, 2017

Good catch. reloading.js is not intended to be transpiled. My bad. #156 fixes this!

@milankinen milankinen added the bug label Apr 20, 2017
@milankinen
Copy link
Owner

Oh nice! 👍 My fault, I reviewed the code but didn't notice this

milankinen added a commit that referenced this issue Apr 20, 2017
Fixes #155: Remove template literals from reloading.js
@milankinen
Copy link
Owner

4.0.0-beta.2 (also tagged as next)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants