Added missing function definitions resolves #64 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avleenk2312
changed the title
milankl
reviewed
Jun 29, 2023
|
I guess the failed checks were already there for Float16sr, right? |
milankl
added a commit
that referenced
this pull request
Jun 29, 2023
Yes I believe there's something wrong with the subnormals (probably in general) but because there's so rarely used, it only shows up with Float16sr. I need to look into this. The probably at the moment is that it happens a (only very) few times that the rounding error is more than |
milankl
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As resolved by you the following function definitions have been added to Float16sr and Float32sr for compatibility with GenericFFT:
I have tested the code. It works well with GenericFFT.
Also, I use mod function in PIC so I have added the definition for it under basic operations as well for both Float16sr and Float32sr.