Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MediaEmbed for video filter #158

Open
dereuromark opened this issue Sep 19, 2020 · 1 comment
Open

Use MediaEmbed for video filter #158

dereuromark opened this issue Sep 19, 2020 · 1 comment
Labels

Comments

@dereuromark
Copy link
Collaborator

The Video standalone filter is nice for starters.
But the issue is that you need to also maintain those video links/URLs/code all the time.
It could be beneficial to let a dedicated library take care of that
E.g. https://github.com/dereuromark/media-embed

To have BC and the choice we could add an optional
MediaEmbedVideoFilter which only adds the dependency as require-dev for testing
If you want to use you add the real dependency, otherwise no harm.

The working code can be seen here:
https://github.com/dereuromark/cakephp-markup/blob/master/src/Bbcode/Decoda/VideoFilter.php

What do you think?
Worth porting into, or should this be kept outside as own package shipping?

@alquerci
Copy link
Contributor

Nice work @dereuromark .

To have BC and the choice we could add an optional

Why to not use it on VideoFilter totally transparently to supports more providers.
Does current VideoFilter interface can support all providers?
Does your library is enough extendible in order to adapt VideoFilter interface to media-embed lib?

=> So there will be no BC break but more provider support.

Worth porting into, or should this be kept outside as own package shipping?

=> be kept outside as own package shipping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants